svn commit: samba r21549 - in branches/SAMBA_3_0/source/rpc_server: .

Jeremy Allison jra at
Tue Feb 27 07:04:47 GMT 2007

On Mon, Feb 26, 2007 at 10:44:24PM +0000, vlendec at wrote:
> Author: vlendec
> Date: 2007-02-26 22:44:24 +0000 (Mon, 26 Feb 2007)
> New Revision: 21549
> WebSVN:
> Log:
> Only create DISP_INFO structs for domain handles, the others don't need
> them. It just does not make sense to do a querydispinfo on an alias handle...
> This fixes a memleak: Every samr_connect*() call leaked a DISP_INFO for the
> (NULL) sid.
> More cleanup pending: Essentially, we only need the DISP_INFO cache for the
> get_global_sam_sid() domain. BUILTIN is fixed and small enough, and there are
> no other domains around where enumerations could happen.
> This also removes the explicit builtin_domain flags. I don't think this is
> worth it. If this makes a significant difference, then we have a *VERY* tuned
> RPC layer...
> Jeremy, please check this. If it's ok, we might want to merge it across.

I'll check it, but you need to merge things across yourself
more please. I'm travelling too much to be reliable on this
and I might miss something that we need.

Please do this yourself :-).


More information about the samba-technical mailing list