netr_LogonLevel patch

Stefan (metze) Metzmacher metze at samba.org
Fri Feb 23 09:07:27 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett schrieb:
> On Fri, 2007-02-23 at 09:05 +0100, Stefan (metze) Metzmacher wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi Andrew,
>>
>> would it be ok to commit this patch without testing?
>> so that it isn't lost.
>>
>> it's based on Luke's ethereal patch here
>> http://arkiv.netbsd.se/?ml=samba-technical&a=2004-02&t=42845
>>
>> I also have the impression that we don't test all validation levels
>> and all logon levels in our torture tests.
>>
>> I only see validation level 3 tested.
> 
> In the RPC-SAMLOGON test we test level 2, 3 and 6.

but never the PacInfo...

> I would like to see that test expanded to also test this.  At the very
> least, the RPC-NETLOGON test should be expanded to ensure we at least do
> not fault, even if we don't get the internals right at this point.

then I'll not commit as I have no time for writing a test

metze

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFF3q7Pm70gjA5TCD8RAt7iAJ0Sm28SPJd7IGJtR6akuACC2SjnoQCgric8
6Wzsf7nDRcPFUDlafIVXQGM=
=vIki
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list