bitmaps as special enums?

Stefan (metze) Metzmacher metze at samba.org
Wed Feb 21 18:32:11 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij schrieb:
> Hi Tridge,
> 
> Bitmaps and enums are similar in a lot of cases. I'd like to merge them
> into one type but have an attribute of some sort to indicate that
> multiple values can be used. In other words, I'd like to make bitmaps a
> special kind of enums.
> 
> This has the following advantages:
> 
>  * Less code duplication (distinction is mainly important for the
> wireshark dissector and the print functions). 
>  * Better portability (other IDL compilers don't support bitmaps).
> 
> Since you are the original author of this code, would you object to
> having this changed? Or perhaps any disadvantages to the approach I'm
> proposing that you can think of?

Wasn't I the author of the 'bitmap' feature?
I need to think about it, and will reply more detailed tomorrow...

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFF3JAqm70gjA5TCD8RArjMAJ48yJwfnBHZfurveJH71V+XGBj08gCgs7QM
kL1XdlHR51twyKXA1+dqE2Y=
=yR2Q
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list