[SAMBA4][PATCH] Enable 'make wintest_dc'

Andrew Bartlett abartlet at samba.org
Wed Feb 21 10:27:27 GMT 2007


On Tue, 2007-02-20 at 21:20 -0600, Brad Henry wrote:
> Andrew Bartlett wrote:
> > On Tue, 2007-02-20 at 16:36 -0600, Brad Henry wrote:
> >> Hello, I would like to propose the following patch.
> >>
> >> It creates a new test to run with make, called 'wintest_dc'. I am 
> >> planning to use it as the basis for automated Windows 2003 DC testing in 
> >> the build farm. It takes advantage of the changes and test scripts which 
> >> I've committed today.
> > 
> > Why does it need to be a different test?  Can't we do the normal windows
> > testing, then promote the machine to a DC as a single test?
> > 
> > Andrew Bartlett
> > 
> 
> The only reason I can think of is that in the case where we fail a lot 
> of DC tests, it will take time to restore the snapshot and promote the 
> base image to a DC for each failed test. Working from a base DC image 
> saves us from having to promote each time.

Can we run two images, but just from one test target, if that is more
efficient?

> It's just as easy for me to add the DC tests to the existing windows 
> tests though. Would you rather I do that?

My gut feeling is that we want one 'external windows test' target.  We
already have to many 'test-like' targets in main.mk.  

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20070221/fcac3cfe/attachment.bin


More information about the samba-technical mailing list