[SAMBA4][PATCH] Handle search_options control in LDB

Andrew Bartlett abartlet at samba.org
Tue Feb 20 21:43:09 GMT 2007

On Tue, 2007-02-20 at 08:24 -0500, simo wrote:
> On Tue, 2007-02-20 at 18:00 +1100, Andrew Bartlett wrote:
> > Attached please find a patch to implement the server_side of the
> > search_options control, for the 'phantom root' bit (only).
> Can you also implement the other bit?

I'm not entirely clear on it's behaviour.

> > This also includes code to modify the LDAP server to set this flag on
> > the global catalog port, and tests to verify the behaviour.
> Seems ok for now. I still think we will have to create a separate ldb
> for the global catalog in future, but I am not pushing that right now.
> > I would like comments on the ldb changes, required because I needed a
> > way to handle controls from ejs, and from the LDAP server.
> Why did you put ldb_parse_control_strings() in ldb_private.h ?

I was squeamish about extending the public API.  

> It should be put in ldb.h, the private one is for functions that are
> used internally only. Please move it there. Also please fix the wrong
> comments on the OIDs not just remove them.
> Over all I like the patch, please fix details and commit it.

OK, thanks.

Andrew Bartlett
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20070221/2793a0ec/attachment.bin

More information about the samba-technical mailing list