svn commit: samba r21461 - in branches/SAMBA_3_0/source/smbd: .
jra at samba.org
Tue Feb 20 16:59:52 GMT 2007
On Tue, Feb 20, 2007 at 12:16:21PM +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2007-02-20 12:16:20 +0000 (Tue, 20 Feb 2007)
> New Revision: 21461
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=21461
> Not strictly necessary, as data_blob() panics if it can't allocate. But I'd
> see this as a design flaw in data_blob() and it made me look in that routine.
> Jeremy, revert or merge please :-)
I'll merge it, but yes I looked in lib/data_blob first :-).
I agree it's a design flaw. We'd have to go look for all
cases where data_blob() isn't checked. There are probably
lots - and tridge argues (and I think he's right) that
terminating in this case is the right thing to do.
More information about the samba-technical