[SAMBA4][PATCH] Handle search_options control in LDB
idra at samba.org
Tue Feb 20 13:24:47 GMT 2007
On Tue, 2007-02-20 at 18:00 +1100, Andrew Bartlett wrote:
> Attached please find a patch to implement the server_side of the
> search_options control, for the 'phantom root' bit (only).
Can you also implement the other bit?
> This also includes code to modify the LDAP server to set this flag on
> the global catalog port, and tests to verify the behaviour.
Seems ok for now. I still think we will have to create a separate ldb
for the global catalog in future, but I am not pushing that right now.
> I would like comments on the ldb changes, required because I needed a
> way to handle controls from ejs, and from the LDAP server.
Why did you put ldb_parse_control_strings() in ldb_private.h ?
It should be put in ldb.h, the private one is for functions that are
used internally only. Please move it there. Also please fix the wrong
comments on the OIDs not just remove them.
Over all I like the patch, please fix details and commit it.
Samba Team GPL Compliance Officer
email: idra at samba.org
More information about the samba-technical