[SAMBA 4] Problems adding a new test

Brad Henry j0j0 at riod.ca
Mon Feb 19 19:23:17 GMT 2007

Jelmer Vernooij wrote:
> On Mon, 2007-02-19 at 13:09 -0600, Brad Henry wrote:
>> Jelmer Vernooij wrote:
>>> On Mon, 2007-02-19 at 08:37 -0600, Brad Henry wrote: 
>>>> I'm trying to add Samba 4 testing against a Windows 2003 DC, starting 
>>>> with the included reference patch.
>>>> The recipe seems to be generated correctly in source/st/recipe, but I 
>>>> don't think it gets run.
>>>> When I add this patch, set the permissions of 
>>>> source/script/tests/tests_win2k3_dc.sh to make it executable, recompile, 
>>>> and run 'make wintest_dc', it reports 0 failures, although both tests 
>>>> fail if I try to run them by hand.
>>>> Any idea what I'm doing wrong here?
>>> The current implementation of "testit" only schedules a test for
>>> running, it doesn't actually run the test yet.
>>> This means that the line that echoes the number of errors is actually
>>> run before the tests. 
>> That looks like what's been happening with the existing windows build 
>> farm tests (on bnhtest) as well.
>> How can I get the test, once scheduled, to run? Should I be using 
>> something other than "testit" altogether?
> selftest.sh will take care of that for you. If you're not using
> selftest.sh (I haven't looked into the windows scripts), you should
> probably use something else than testit.
> Cheers,
> Jelmer

I'm using selftest.sh for these tests and for the existing windows tests.

I just realized that the problem is happening because the test script 
exits at the end. If I remove 'testok $0 $all_errs' and 'exit $status', 
the test fails properly. :)


More information about the samba-technical mailing list