svn commit: samba r21278 - in branches/SAMBA_3_0/source/smbd: .
jpeach at samba.org
Sat Feb 17 18:19:08 GMT 2007
On 17/02/2007, at 5:02 AM, Volker Lendecke wrote:
> On Sat, Feb 17, 2007 at 01:18:49PM +0100, Volker Lendecke wrote:
>> On Sun, Feb 11, 2007 at 05:59:53PM -0800, Jeremy Allison wrote:
>>> Can you run cachegrind on both methods to see why the
>>> memcpy ends up taking less time ?
>> Ok, without the patch for 10000 runs cachegrind says:
> Hmm. I take everything back :-)
> I got fooled by -DDEVELOPER and clobber_region. Without that
> both versions just don't show any significant difference:
> Then the argument would be that with the patch we gain some
> code simplicity, which was the original goal :-)
My 2c is that these sorts of changes will have variable impact
depending on the machine architecture and system libraries, eg. the
system's memory bandwidth and malloc implementation. You should go
for whichever code is cleanest.
James Peach | jpeach at samba.org
More information about the samba-technical