svn commit: samba r21338 - in branches/SAMBA_4_0: . source/pidl/lib/Parse/Pidl/Samba3 source/pidl/tests

[Jelmer Vernooij]

Hi Stefan,

On Wed, 2007-02-14 at 16:25 +0100, Stefan (metze) Metzmacher wrote: 
> jelmer at samba.org schrieb:
> > @@ -99,7 +129,7 @@
> >  	} elsif ($fn->{RETURN_TYPE} eq "WERROR") {
> >  		pidl "return werror_to_ntstatus(r.out.result);";
> >  	} else {
> > -		pidl "/* Sorry, don't know how to convert $fn->{RETURN_TYPE} to NTSTATUS */";
> > +		pidl "#warning Sorry, don't know how to convert $fn->{RETURN_TYPE} to NTSTATUS";
> >  		pidl "return NT_STATUS_OK;";
> Hi Jelmer,
> 
> #warning isn't supported by all compilers, and I think pidl should just
> reject to compile the file...
Oops, good point.

Rejecting non-NTSTATUS|WERROR return types is not really an option, as
pidl needs to be able to generate parsers for functions that return
uint32, for example. Interfaces that have these return types include
echo and epmapper. Ideally, we should support client functions that
return non-NTSTATUS things or perhaps add a fake "uint32 *result"
parameter in these cases.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20070215/85591c18/attachment.bin