svn commit: samba r21338 - in branches/SAMBA_4_0: . source/pidl/lib/Parse/Pidl/Samba3 source/pidl/tests

David Collier-Brown davec-b at rogers.com
Wed Feb 14 15:37:22 GMT 2007


   #warning does seem to cause diagnostics on the compilers which don't know
what it means... is there a case where it's silently ignored and the bad code
just compiles to a non-running executable?

--dave

Stefan (metze) Metzmacher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> jelmer at samba.org schrieb:
> 
> 
>>@@ -99,7 +129,7 @@
>> 	} elsif ($fn->{RETURN_TYPE} eq "WERROR") {
>> 		pidl "return werror_to_ntstatus(r.out.result);";
>> 	} else {
>>-		pidl "/* Sorry, don't know how to convert $fn->{RETURN_TYPE} to NTSTATUS */";
>>+		pidl "#warning Sorry, don't know how to convert $fn->{RETURN_TYPE} to NTSTATUS";
>> 		pidl "return NT_STATUS_OK;";
> 
> Hi Jelmer,
> 
> #warning isn't supported by all compilers, and I think pidl should just
> reject to compile the file...
> 
> metze
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
> Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
> 
> iD8DBQFF0ynQm70gjA5TCD8RAto0AJ9CYbkfBsFqIlcefiUmQEQ7i/dGFACfdWUt
> 1qkXMo9fOoZpAqt9+1kUyrA=
> =kp/J
> -----END PGP SIGNATURE-----
> 

-- 
David Collier-Brown,         | Always do right. This will gratify
System Programmer and Author | some people and astonish the rest
davecb at spamcop.net           |                      -- Mark Twain
(416) 223-5943


More information about the samba-technical mailing list