[Summary] Bugzilla Day, Feb 8

Thomas Bork tombork at web.de
Fri Feb 9 20:04:25 GMT 2007


Gerald (Jerry) Carter wrote:

> I've posted a short summary of the bug bash from yesterday
> at http://wiki.samba.org/index.php/Bugzilla_Day#8_Feb_2007.
> I've also updated the suggested patches for 3.0.24 at
> http://www.samba.org/samba/patches/.  All of these are fixes
> for problems with Vista clients.

I'm *still* missing:

--- source/rpc_server/srv_spoolss.c Tue Jan 30 08:13:10 2007
+++ source/rpc_server/srv_spoolss.c-rev21047 Tue Jan 30 08:13:12 2007
@@ -910,6 +910,15 @@
         ZERO_STRUCT(r_u);

         if(!spoolss_io_q_addprinterdriver("", &q_u, data, 0)) {
+               if (q_u.level != 3 && q_u.level != 6) {
+                       /* Clever hack from Martin Zielinski <mz at seh.de>
+                        * to allow downgrade from level 8 (Vista).
+                        */
+                       DEBUG(3,("api_spoolss_addprinterdriver: unknown 
SPOOL_Q_ADDPRINTERDRIVER level %u.\n",
+                               (unsigned int)q_u.level ));
+                       setup_fault_pdu(p, 
NT_STATUS(DCERPC_FAULT_INVALID_TAG));
+                       return True;
+               }
                 DEBUG(0,("spoolss_io_q_addprinterdriver: unable to 
unmarshall SPOOL_Q_ADDPRINTERDRIVER.\n"));
                 return False;
         }

-- 
der tom


More information about the samba-technical mailing list