wbinfo -K NULL pointer dereference

[SATOH Fumiyasu]

Hi,

I'm using Samba 3.0.23d on Solaris 10.

  # wbinfo -K user%pass
  ...
  Segmentation Fault (core dumped)
  # pstack core
  core 'core' of 5283:    /opt/osstech/bin/wbinfo -K user%pass
   fec84c7c strlen   (80dd761, 80464cc, 8046410, 0) + c
   fecdd3cb vsnprintf (0, 0, 80dd714, 80464cc) + 73
   08092cd6 vasprintf (804648c, 80dd714, 80464cc) + 26
   08092e3b d_vfprintf (811a948, 80dd714, 80464cc) + 4b
   08092ffd d_printf (80dd714, 8047918, 810d008, 0) + 3d
   080641d9 wbinfo_auth_krb5 (8047918, 0, 7002) + 179
   08065932 main     (3, 8047dfc, 8047e0c) + 702
   08062a6a _start   (3, 8047eb8, 8047ed0, 8047ed3, 0, 8047ee2) + 7a

Is the following patch correct?

Index: SAMBA_3_0/source/nsswitch/wbinfo.c
===================================================================
--- SAMBA_3_0/source/nsswitch/wbinfo.c	(revision 21239)
+++ SAMBA_3_0/source/nsswitch/wbinfo.c	(working copy)
@@ -1453,7 +1453,6 @@ int main(int argc, char **argv, char **e
 							  "KCM", 
 							  "KCM:0", 
 							  "Garbage", 
-							  NULL, 
 							  "0"};
 
 				arg[0] = string_arg;

-- 
-- Name: SATOH Fumiyasu / fumiyas @ osstech.co.jp
-- Business Home: http://www.OSSTech.co.jp
-- Personal Home: http://www.SFO.jp/blog/