Bugzilla day wiki page is up

[Thomas Bork]

Gerald (Jerry) Carter wrote:

> See http://wiki.samba.org/index.php/Bugzilla_Day for links to the
> current Vista patch set and open bugs. Thanks.

Missing this against 3.0.24:

--- source/rpc_server/srv_spoolss.c Tue Jan 30 08:13:10 2007
+++ source/rpc_server/srv_spoolss.c-rev21047 Tue Jan 30 08:13:12 2007
@@ -910,6 +910,15 @@
         ZERO_STRUCT(r_u);

         if(!spoolss_io_q_addprinterdriver("", &q_u, data, 0)) {
+               if (q_u.level != 3 && q_u.level != 6) {
+                       /* Clever hack from Martin Zielinski <mz at seh.de>
+                        * to allow downgrade from level 8 (Vista).
+                        */
+                       DEBUG(3,("api_spoolss_addprinterdriver: unknown 
SPOOL_Q_ADDPRINTERDRIVER level %u.\n",
+                               (unsigned int)q_u.level ));
+                       setup_fault_pdu(p, 
NT_STATUS(DCERPC_FAULT_INVALID_TAG));
+                       return True;
+               }
                 DEBUG(0,("spoolss_io_q_addprinterdriver: unable to 
unmarshall SPOOL_Q_ADDPRINTERDRIVER.\n"));
                 return False;
         }


And this (not vista related, correctly hiding shares with last char '$':

--- source/rpc_server/srv_srvsvc_nt.c   Wed Aug 30 20:08:38 2006
+++ source_new/rpc_server/srv_srvsvc_nt.c       Sun Feb  4 18:31:36 2007
@@ -44,7 +44,7 @@
                 type = STYPE_PRINTQ;
         if (strequal(lp_fstype(snum), "IPC"))
                 type = STYPE_IPC;
-       if (net_name[len_net_name] == '$')
+       if (net_name[len_net_name-1] == '$')
                 type |= STYPE_HIDDEN;

         return type;


And this (not vista related, allowing NT 4.0 clients on Samba PDC):

--- source/include/rpc_samr.h   Fri Jun  9 21:30:31 2006
+++ source/include/rpc_samr.h   Fri Dec  8 00:07:18 2006
@@ -222,7 +222,7 @@
  typedef struct sam_user_info_24
  {
         uint8 pass[516];
-       uint16 pw_len;
+       uint8 pw_len;
  } SAM_USER_INFO_24;

  /*
--- source/rpc_parse/parse_samr.c       Tue Nov 14 15:42:14 2006
+++ source/rpc_parse/parse_samr.c       Fri Dec  8 00:05:16 2006
@@ -5587,7 +5587,8 @@
   init_sam_user_infoa
 
*************************************************************************/

-void init_sam_user_info24(SAM_USER_INFO_24 * usr, char newpass[516], 
uint16 pw_len)
+void init_sam_user_info24(SAM_USER_INFO_24 * usr, char newpass[516],
+              uint8 pw_len)
  {
         DEBUG(10, ("init_sam_user_info24:\n"));
         memcpy(usr->pass, newpass, sizeof(usr->pass));
@@ -5615,10 +5616,10 @@
                 return False;

         if (MARSHALLING(ps) && (usr->pw_len != 0)) {
-               if (!prs_uint16("pw_len", ps, depth, &usr->pw_len))
+               if (!prs_uint8("pw_len", ps, depth, &usr->pw_len))
                         return False;
         } else if (UNMARSHALLING(ps)) {
-               if (!prs_uint16("pw_len", ps, depth, &usr->pw_len))
+               if (!prs_uint8("pw_len", ps, depth, &usr->pw_len))
                         return False;
         }


-- 
der tom
[eisfair-team]