svn commit: samba r21191 - in branches/SAMBA_3_0/source: include libsmb locking param rpc_server smbd

[Volker Lendecke]

On Tue, Feb 06, 2007 at 02:24:04PM -0800, Jeremy Allison wrote:
> On Tue, Feb 06, 2007 at 11:22:11PM +0100, Volker Lendecke wrote:
> > Quick question -- Looking at the code in trans2.c the logic
> > mapping between the trans2 posix open/unlink/etc calls and
> > the native ones is very small. Can't this be done in the
> > client? Why bother with a whole new set of calls when you
> > can get this with a normal ntcreate?
> 
> Hay - do you realize how much work I had to do to make
> that mapping so small :-) :-) :-) ?

Hey, do you realize how much more readable the patch would
have been if you had split out the BOOL->NTSTATUS change for
close() :-)))

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070206/a9872c32/attachment.bin