[PATCH] Wrap the DEBUG checks in a "unlikely"

James Peach jorgar at gmail.com
Fri Dec 28 05:35:19 GMT 2007


On 28/12/2007, Volker Lendecke <vl at samba.org> wrote:
> On my Laptop with some limited netbench runs this gains about 1.5% of
> performance. When looking at the assembler output I would suspect the biggest
> gain is by the fact that with this in place the calls to the debug functions is
> moved to the function end, out of the way of the normal code paths. valgrind
> tests pending I would suspect this to be much more cache friendly.
>
> Comments?

ISTR  doing this for IRIX giving betwen 2% and 5%. Compiler and
architecture dependent, but definitely worthwhile.

-- 
James Peach | jorgar at gmail.com


More information about the samba-technical mailing list