[PATCH] Wrap the DEBUG checks in a "unlikely"

Jeremy Allison jra at samba.org
Thu Dec 27 18:19:15 GMT 2007


On Thu, Dec 27, 2007 at 05:41:19PM +0100, Volker Lendecke wrote:
> On my Laptop with some limited netbench runs this gains about 1.5% of
> performance. When looking at the assembler output I would suspect the biggest
> gain is by the fact that with this in place the calls to the debug functions is
> moved to the function end, out of the way of the normal code paths. valgrind
> tests pending I would suspect this to be much more cache friendly.
> 
> Comments?

Yes. Please push once you've valgrind tested ! :-). 1.5%
is not to be left on the table :-).

Jeremy.


More information about the samba-technical mailing list