[SCM] Samba Shared Repository - branch v3-2-test updated -
Volker.Lendecke at SerNet.DE
Wed Dec 26 13:40:39 GMT 2007
On Wed, Dec 26, 2007 at 12:26:48PM +0000, idra at samba.org wrote:
> I thought that talloc_stackframe() was to be used in functions that were
> difficult to convert to use talloc contexts. Why this removal of
> existing and working context passing ??
Well, here I have to agree with Michael. From an API point
of view there's no point to pass a temporary talloc context
to libnet_smbconf_set_global_param(), I think we should only
pass talloc contexts when there's something that will be
returned. In this sense talloc_stackframe() is just
allocating a temporary talloc ctx. Using that is preferable
IMO to talloc_new(), because it will cause lower-level
errors not to free memory to be corrected earlier.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20071226/9cf8bd2e/attachment.bin
More information about the samba-technical