remove doschar_table[] ?

simo idra at samba.org
Mon Dec 17 03:15:38 GMT 2007


On Sun, 2007-12-16 at 00:35 +0100, Volker Lendecke wrote:
> Hi, Simo!
> 
> Last time I did this you objected, but I forgot your
> argument, sorry. Can you comment on the attached patchset?
> (and push it if you agree?)

Jeremy already pushed it, however it seem this is ok.
I've re-read the code paths and it seem the tables are recreated only
when the dos codepage changes, so it is fine.

Any reason why you did not remove torture/t_doschar.c ?

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>



More information about the samba-technical mailing list