remove doschar_table[] ?

Jeremy Allison jra at
Sun Dec 16 01:31:41 GMT 2007

On Sun, Dec 16, 2007 at 12:35:45AM +0100, Volker Lendecke wrote:
> Subject: [PATCH] get rid of doschar_table[]
> If I'm not completely blind, then check_dos_char is *only* used in the case
> when we can't mmap() valid.dat. To me this looks as if we initialize the 65536
> bits in doschar_table[] with check_dos_char_slowly, use it once to initialize
> valid_table[] and *never* use them again. I think there's no point in keeping
> these 8k of modified memory around for an unlikely case (no "valid.dat") and
> even that only to use it exactly once.

This is 100% correct. I intend to push unless you have serious
objections Simo this as getting back 8k here is not to be ignored
with the recent wins we've been getting in 3.2.

I'll wait until tomorrow to see if there are any comments on
this. Well spotted Volker !


More information about the samba-technical mailing list