Remove unused stuff from winbindd

[simo]

On Wed, 2007-12-12 at 08:39 -0600, Gerald (Jerry) Carter wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Stefan (metze) Metzmacher wrote:
> > Hi,
> > 
> > I'd like to remove some unused code from winbindd:
> > 
> > - WINBINDD_DUAL_UID2NAME, WINBINDD_DUAL_NAME2UID, WINBINDD_DUAL_GID2NAME
> >   and WINBINDD_DUAL_NAME2GID are not used at all anywhere.
> > 
> > - WINBINDD_DUMP_MAPS is not used anywhere. Also the disign
> >   of it is really bad (the client passes a filename and winbindd
> >   dumps to this file on the local filesystem).
> 
> No objection to removing these.
> 
> >   It would be better to implement a function that returns all mapping
> >   to the client and the client can display or store the content.
> > 
> > - WINBINDD_DUAL_SIDS2XIDS is disabled (#if 0) currently and I'd like to
> >   remove it. Unused code is broken code and we can get it easily back
> >   from the git history.
> 
> Please leave this as it is on my plate to fix.  Have
> to translate uids/gids one at a time is really a huge
> performance hit gfot large number of groups.

Jerry,
wrt this I remember we discussed moving the cache into the main
winbindd.
I still think this is a good idea, are you working on that yet?

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>