Remove unused stuff from winbindd
Gerald (Jerry) Carter
jerry at samba.org
Wed Dec 12 14:39:52 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Stefan (metze) Metzmacher wrote:
> I'd like to remove some unused code from winbindd:
> - WINBINDD_DUAL_UID2NAME, WINBINDD_DUAL_NAME2UID, WINBINDD_DUAL_GID2NAME
> and WINBINDD_DUAL_NAME2GID are not used at all anywhere.
> - WINBINDD_DUMP_MAPS is not used anywhere. Also the disign
> of it is really bad (the client passes a filename and winbindd
> dumps to this file on the local filesystem).
No objection to removing these.
> It would be better to implement a function that returns all mapping
> to the client and the client can display or store the content.
> - WINBINDD_DUAL_SIDS2XIDS is disabled (#if 0) currently and I'd like to
> remove it. Unused code is broken code and we can get it easily back
> from the git history.
Please leave this as it is on my plate to fix. Have
to translate uids/gids one at a time is really a huge
performance hit gfot large number of groups.
Samba ------- http://www.samba.org
Likewise Software --------- http://www.likewisesoftware.com
"What man is a man who does not make the world better?" --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the samba-technical