[PATCH][Samba4] Fix warnings in auth/gensec/
Stefan (metze) Metzmacher
metze at samba.org
Wed Dec 12 10:39:40 GMT 2007
Kai Blin schrieb:
> Hi folks,
>
> the attached patch fixes the warnings in auth/gensec/
>
> I'm not 100% certain on the fix to gensec_gssapi.c const gss_OID_desc
> *gss_oid; --> gss_OID gss_oid;
I think that's fine.
> @@ -358,9 +362,11 @@ int gensec_sasl_log(void *context,
> NTSTATUS gensec_sasl_init(void)
> {
> NTSTATUS ret;
> - int sasl_ret, i;
> - const char **sasl_mechs;
> -
> + int sasl_ret;
> + /* Needed for #else path in #if 1 below, so left in for documentation
> + int i;
> + const char **sasl_mechs; */
> +
Please leave that in, so that we get the warning!
We can remove it is we remove the #else part
(which you should discuss with abartlet).
The rest looks ok.
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20071212/369d15f4/signature.bin
More information about the samba-technical
mailing list