Remove unused stuff from winbindd
idra at samba.org
Wed Dec 12 08:09:37 GMT 2007
On Wed, 2007-12-12 at 08:56 +0100, Stefan (metze) Metzmacher wrote:
> I'd like to remove some unused code from winbindd:
> - WINBINDD_DUAL_UID2NAME, WINBINDD_DUAL_NAME2UID, WINBINDD_DUAL_GID2NAME
> and WINBINDD_DUAL_NAME2GID are not used at all anywhere.
> - WINBINDD_DUMP_MAPS is not used anywhere. Also the disign
> of it is really bad (the client passes a filename and winbindd
> dumps to this file on the local filesystem).
> It would be better to implement a function that returns all mapping
> to the client and the client can display or store the content.
Yeah kill this please.
> - WINBINDD_DUAL_SIDS2XIDS is disabled (#if 0) currently and I'd like to
> remove it. Unused code is broken code and we can get it easily back
> from the git history.
Except for this which I'd like to revive soon.
Samba Team GPL Compliance Officer <simo at samba.org>
Senior Software Engineer at Red Hat Inc. <ssorce at redhat.com>
More information about the samba-technical