[PATCH] Don't copy the rpc function pointers

Andrew Bartlett abartlet at samba.org
Mon Dec 10 07:11:30 GMT 2007

On Mon, 2007-12-10 at 08:02 +0100, Volker Lendecke wrote:
> On Mon, Dec 10, 2007 at 09:07:00AM +1100, Andrew Bartlett wrote:
> > > Pushing - and thanks a *lot* ! :-).
> > 
> > Does the squashing of a couple of LSA operations when we are not being
> > an 'ADS server' have anything to do with this?  (Hopefully that code is
> > long removed, but I know the list of operations was messed with for
> > that). 
> Shouldn't this have been detected by the compiler when I
> changed 
>         } pipe;                                                                 
> -       struct api_struct *cmds;
> +       const struct api_struct *cmds;
>         int n_cmds;

It was actually (see srv_lsa.c) handled by decrementing the count.  It's
all subject to a '#if 0', so no worry there anyway.  Unless the
documentary value is large, perhaps we should remove that code

Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20071210/4d94580e/attachment.bin

More information about the samba-technical mailing list