[PATCH] Don't copy the rpc function pointers

Andrew Bartlett abartlet at samba.org
Sun Dec 9 22:07:00 GMT 2007


On Sun, 2007-12-09 at 11:12 -0800, Jeremy Allison wrote:
> On Sun, Dec 09, 2007 at 07:46:06PM +0100, Volker Lendecke wrote:
> > This actually shows up in a valgrind massif run with 4.1% of allocated memory.
> > I don't see why we would have to make a copy here.
> 
> This is obvious goodness. Probably left over from the time
> when we were designing the interface and thought about
> dynamic pipes.
> 
> Pushing - and thanks a *lot* ! :-).

Does the squashing of a couple of LSA operations when we are not being
an 'ADS server' have anything to do with this?  (Hopefully that code is
long removed, but I know the list of operations was messed with for
that). 

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20071210/71d72bc9/attachment.bin


More information about the samba-technical mailing list