Jeremy Allison jra at
Sun Dec 2 06:21:56 GMT 2007

On Sun, Dec 02, 2007 at 12:20:13AM +0100, Volker Lendecke wrote:
> Hi!
> Attached find a patch that consolidates reply_ntcreate and
> call_nttrans_create with create_file. From the patch you
> can't really see what's going on, but I took the common
> parts of both routines and put them into one routine with a
> monster parameter list (19...). But when you look at other
> path handling reply_xxx calls, some of them could also make
> use of this.
> It gets some error codes wrong, working on it.
> Comments?

Looks nice. Please fix the error codes and let's
go with it :-). It's about time that code got
unified, one is just an ACL case of another.



More information about the samba-technical mailing list