[proof of concept] libwbclient.so

[James Peach]

On 30/08/2007, Gerald (Jerry) Carter <jerry at samba.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> James,
>
> > I like the idea. Some comments about the API ....
> >
> > I don't much like having the API allocate strings for
> > all the SIDs. If you defined a binary SID type, callers
> > would only have to allocate when they called wbcSidToString().
>
> This brings up the question of whether or not to expose the SID
> structure.  In an effort to maintain the LGPL status of the lib,
> I stripped out most Samba data structures.  We can expose DOM_SID
> and related parsing routines as long as people agree its ok.
> That would make separating smbd & winbindd easier for me.

IMHO you need this for this interface to be useful from non-Samba apps.

> > The SUCCESS/FAIL values of wbcStatus are OK, but if you are going to
> > make wbcStatus more detailed I'd suggest renaming WBC_FAIL to
> > WBC_UNKNOWN_ERROR or something.
>
> Agreed.  That was just a placeholder rather than BOOL or int
> for return values.  In general though, you agree with all
> functions returning a library specific error code, correct?

yes, you need to know "unknown uid" and stuff like that

-- 
James Peach | jorgar at gmail.com