Bug in DFS code ion SAMBA_3_2_0

Jeremy Allison jra at samba.org
Fri Aug 17 21:01:39 GMT 2007


On Fri, Aug 17, 2007 at 10:56:49PM +0200, Volker Lendecke wrote:
> Hi, Jeremy!
> 
> On Fri, Aug 17, 2007 at 09:35:12AM -0700, Jeremy Allison wrote:
> > Ok - then we're good to go for 3.0.25c. This is probably
> > the unix_convert issue Volker already knows about.
> 
> Now I know at least what it is: In case of failure we need
> to copy back the already converted part of the path to the
> parent. Right now we don't do that, and for a "good" API I
> would much rather see that we give that back as in a
> separate argument. The fix I put in broke other tests, as in
> some parts during the unix_convert loop over the path
> components it seems that I did not yet fully understand the
> loop invariants of the variables dirname, start, end, name
> etc. If you can't stand it, feel free to look at it,
> although I would in the end like to nail it my self. But not
> tonight anymore, it's 11pm here.

Might have to wait until Monday, I'm drowning in "stuff" here :-).

Thanks, I'll definately look now you've said I can though :-).

Have a good weekend.


More information about the samba-technical mailing list