Compile warnings in libsmbclient.c

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Aug 14 06:18:54 GMT 2007


Hi, Derrell!

With r24388 I'm getting:


Compiling libsmb/libsmbclient.c
libsmb/libsmbclient.c: In function ‘cacl_set’:
libsmb/libsmbclient.c:5145: warning: passing argument 1 of ‘prs_mem_free’ from incompatible pointer type
libsmb/libsmbclient.c:5146: warning: passing argument 1 of ‘prs_mem_free’ from incompatible pointer type
libsmb/libsmbclient.c:5165: warning: passing argument 1 of ‘prs_mem_free’ from incompatible pointer type
libsmb/libsmbclient.c:5166: warning: passing argument 1 of ‘prs_mem_free’ from
incompatible pointer type

Looking at the code

                prs_mem_free(old->dacl->aces);
                prs_mem_free(&old->dacl);

it looks indeed wrong. The aces and the dacl is not a
prs_struct. Doesn't this segfault?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070814/80878c52/attachment.bin


More information about the samba-technical mailing list