[PATCH] Clear spinlocks in TDB

[Volker Lendecke]

On Tue, Aug 07, 2007 at 04:59:16PM +0200, Jelmer Vernooij wrote:
> TDB currently has trouble opening old TDB files that were using
> spinlocks. The attached patch tries to clear up the remaining spinlocks
> if TDB has exclusive write access to the file and should thus allow
> opening older databases that have spinlocks enabled. 
> 
> The clear_spinlocks() code comes from an old version of TDB.
> 
> This was mostly cut-n-paste, I'm familiar with the nasty details of the
> locking in TDB. Can somebody more familiar with the old spinlock code
> review this patch ?

Not having looked too closely, can't we get a flag for
tdbbackup that would just overwrite the spinlock flag before
tdb_open()ing the source tdb? This would not mess with the
main tdb code path and could be marked as an emergency
measure. The admin would have to make sure himself that
nobody uses the tdb.

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070812/22a37370/attachment.bin