[SAMBA4] we should create just one test environment

Jelmer Vernooij jelmer at samba.org
Mon Apr 30 08:22:15 GMT 2007

Hash: SHA1

Andrew Bartlett wrote:
> On Mon, 2007-04-30 at 09:03 +0200, Jelmer Vernooij wrote:
>> Andrew Bartlett wrote:
>> Nothing prevents test environments for guaranteeing both a dc and two
>> members will be up, for example. 
> I'm asking that that be the default, that we create exactly one test
> environment for the vast majority of the tests we run.  
I don't see what that would add. Why should we set up a domain member if
we just one need a dc to run against?

If we'd have one such "sane default", then there is no point in having
multiple environments at all.

>> Also, the current code makes it very easy to add support for other
>> targets (Samba3, for example) that don't support all test environments
>> (yet).
>> Perhaps you would simply like to make sure that all test environments
>> are set up in 'make testenv' ? 
> No, then the tests will constantly differ from the environment in which
> they are normally run, even worse than the current situation.
In that case, why not add an ENV= variable so you can run "make testenv
ENV=member" ? Or perhaps we can simply add "make testenv-dc" and "make

We can print out the environment name for failed tests, if that would help.

> I'm afraid that the selftest setup is becoming too complex to reproduce
> - I want to be able to easily reproduce any failure in 'make
> testenv' (which you will recall is my primary work tool), without first
> wondering 'oh, what environment did it declare, what environment did it
> get, and what environment do I have now'.
That will make other things more complex. For example, we'd need to
change the environment variables to be $DC1_IP, $DC1_USERNAME,
$DC2_PASSWORD, etc because the tests can be run against either of the
dcs or domain member.

It also makes things like "make test TESTS=SAMR" slower as the
provisioning is two or three times as slow.

> It doesn't seem too much of a price to always have a simple network
> running, that contains the DC (or 2), and member servers.  Then we can
> be very consistent in how our tests run, and are debugged. 
It's not just the time it takes to set up the environment, also the fact
that it makes it harder to support other targets (because of the
complexity of the environment they need to support) and the inability to
mix environments.


Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


More information about the samba-technical mailing list