svn commit: samba r22539 - in branches:
jra at samba.org
Sat Apr 28 14:34:40 GMT 2007
On Sat, Apr 28, 2007 at 09:25:50AM +0200, Stefan (metze) Metzmacher wrote:
> can you also update the documentation?
> lib/talloc/talloc.3.xml and lib/talloc/talloc_guide.txt
Sure, I'll try and get to that this weekend.
> Also some torture tests for lib/talloc/testsuite.c would be nice:-)
All I need to add is tests that talloc_strict(ctx,0) returns NULL, yes ?
That's the only change.
> Maybe we should also define that the _strict() versions should be used
> in samba3 and the normal versions in samba4 and backported code.
> So that people doesn't need to guess what they should do,
> as I think that's exactly what you want to prevent with this...
Well to be honest I'd like to make people think very carefully
about using the Xalloc(0) -> realloc(<>0) idiom as I think it's
dangerous in both branches.
More information about the samba-technical