svn commit: samba r22509 - in branches: SAMBA_3_0/source/groupdb SAMBA_3_0_25/source/groupdb

[James Peach]

On 25/04/2007, at 2:32 AM, jerry at samba.org wrote:

> Author: jerry
> Date: 2007-04-25 09:32:03 +0000 (Wed, 25 Apr 2007)
> New Revision: 22509
>
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=22509
>
> Log:
> Fix some memory corruption caused by calling free()
> on talloc()'d memory when adding/removing members
> from Local Groups.

How about changing SAFE_FREE to prevent this sort of thing? eg.

#define SAFE_FREE(x) do { if ((x) != NULL) { \
	SMB_ASSERT(!talloc_is_talloc_pointer(free)); free(x); x=NULL;} }  
while(0)


--
James Peach | jpeach at apple.com