Broken idmap interface design

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

simo wrote:
> On Thu, 2007-04-19 at 12:11 -0500, Gerald (Jerry) Carter wrote:
>> Jeremy Allison wrote:
>>
>>> Indeed. Looking at this interface cold after ignoring
>>> it for a while I think the SID_TYPE enum needs to be
>>> present as input on all calls into a "map SID to XXX".
>>
>> Agreed.  I'm still looking at what would be the minimal
>> appropriate fix.  Simo and I have a call later this afternoon
>> to chat about the current state and how to move forward.
> 
> Ok, we cleared out the problem in the call.
> 
> Jerry is right, we have a layering violation.

Here is a patch bundle

auth_util.patch		Revert create_local_token() to
			the 3.0.24 codebase

idmap_type.patch	Have the caller fillin the
			id_map.xid.type field when
			resolving a SID so that if we allocate
			a new id, we know what type to use

winbindd_api.patch	Remove the WINBINDD_SIDS_TO_XIDS calls
			from the public winbindd interface
			for the 3.0.25 release

idmap_rid.patch		Cleanup the idmap_rid backend to not
			call back into winbindd to resolve
			the SID in order to verify it's type.


This has been compiled but not tested.  Just posting for
review so everyone knows what the proposed solution is.



cheers, jerry
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGJ9lWIR7qMdg1EfYRAirWAKCcxj+WR1Z5lh2R0SBvh9ZurCubqQCgi6yt
8ppOSpWPHXfOxXhd3KYHV9c=
=e/6l
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: auth_util.patch
Type: text/x-patch
Size: 2048 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070419/1f2f90fa/auth_util.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: idmap_rid.patch
Type: text/x-patch
Size: 4039 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070419/1f2f90fa/idmap_rid.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: idmap_type.patch
Type: text/x-patch
Size: 10579 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070419/1f2f90fa/idmap_type.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winbindd_api.patch
Type: text/x-patch
Size: 2092 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070419/1f2f90fa/winbindd_api.bin