typo in tdb_firstkey?

Taj Khattra taj.khattra at gmail.com
Thu Apr 19 20:30:04 GMT 2007


re: samba-4_0 revision r22117

should the F_RDLCK in tdb_firstkey():

    tdb->travlocks.lock_rw = F_RDLCK;

be F_WRLCK - the subsequent unlock in firstkey, and the lock/unlock in
nextkey all use F_WRLCK?

in any case, i was wondering why we take a write-lock on a hash chain
in firstkey/nextkey instead of a read-lock?  (it's only held briefly,
so i don't know if it matters in practice)


More information about the samba-technical mailing list