Broken idmap interface design

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jeremy Allison wrote:

>> Requiring the idmap_tdb code (or idmap_rid) to issues a
>> winbindd client call is wrong and a layering violation.  The
>> caller should specify the SID type which is exactly what
>> the WINBINDD_SID_TO_UID, et. al. calls used to do.
> 
> Indeed. Looking at this interface cold after ignoring
> it for a while I think the SID_TYPE enum needs to be
> present as input on all calls into a "map SID to XXX".

Agreed.  I'm still looking at what would be the minimal
appropriate fix.  Simo and I have a call later this afternoon
to chat about the current state and how to move forward.





cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGJ6K7IR7qMdg1EfYRAgUmAJ9e2RaocmxF4zjVPHx01GB5qtxvxQCfTe6x
/UmbZYG4aAPMMfWcFVQlE+M=
=PCQS
-----END PGP SIGNATURE-----