incorrect event for ComboBox in samba4's swat.module.ldbbrowse

[Rafal Szczesniak]

On Thu, Apr 05, 2007 at 11:37:51PM -0600, John Jorgensen wrote:
> On 4/5/07, Rafal Szczesniak <mimir at samba.org> wrote:
> >I'm sorry but I don't really see event "changeSelected" being used
> >in ComboBox. Could you point me somewhere to the source code ?
> 
> The clearest indicators in the qooxdoo source are in the
> sample code showing how to use ComboBox.
> 
> In fact, I found the problem because I used ldbbrowse as a model
> for some code I wrote, and then only figured out why my
> ComboBox event handler wasn't getting called when I looked lines
> 872 -- 881 of
> ./webapps/qooxdoo-0.6.5-sdk/frontend/application/showcase/source/class/showcase/Application.js:
> 
>  var select = new qx.ui.form.ComboBox();
>      .
>      .
>      .
>  select.addEventListener("changeSelected", function(e) {
>    var locale = e.getData().getLabel();
>    qx.locale.Manager.getInstance().setLocale(locale);
>  });

Thanks for pointing this.

> Actually, I think that the existence of a single item in the database
> list is the only reason that nobody else has noticed the problem
> before. I only noticed it because I cut and pasted some of
> ldbbrowse/Gui.js, and was surprised that my event handler never got
> called. I thinik if you try to add a second item to the list in a test
> copy of ldbbrowse, you'll find that ldbbrowse's event handler isn't
> called either.

Good catch! Thank you for explanation. Fix applied.


cheers,
-- 
Rafal Szczesniak
Samba Team member  http://www.samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.samba.org/archive/samba-technical/attachments/20070409/4c8eb4ae/attachment.bin