svn commit: samba r22132 - in branches:
jpeach at samba.org
Sun Apr 8 22:25:55 GMT 2007
On 08/04/2007, at 12:41 PM, jra at samba.org wrote:
> Author: jra
> Date: 2007-04-08 19:41:47 +0000 (Sun, 08 Apr 2007)
> New Revision: 22132
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?
> I hate inefficiency. Don't call conv_str_size()
> on every pread/sendfile call, initialize these
> variables in an allocated struct at connection
> time and just refer to them directly.
This code is so close to vfs_cacheprime that I'm tempted to suggest
they should be merged. Was there a particular reason you didn't do this?
James Peach | jpeach at samba.org
More information about the samba-technical