tdb_store

[Volker Lendecke]

On Sat, Apr 07, 2007 at 01:33:05PM -0700, Taj Khattra wrote:
> re: samba-4_0 revision r22117
> 
> in tdb_store(), when flag == TDB_INSERT, could we replace the call to
> tdb_exists_hash() with tdb_find() since we already have a write lock
> on the bucket?
> 
> this would save the extra calls to tdb_lock() and tdb_unlock().

Probably yes, but the tdb_lock calls are essentially free,
as they should be in any 1st level cache at this point.

Do you have requirements where this actually matters?

Tridge, any comments?

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20070407/7c45d966/attachment.bin