hi, re: samba-4_0 revision r22117 in tdb_transaction_cancel(), shouldn't we add tdb->num_lockrecs = 0; SAFE_FREE(tdb->lockrecs); inside the if (tdb->num_locks != 0) block? if yes, it seems like num_locks and num_lockrecs are always incremented and decremented in unison, so couldn't we get rid of one of them? thanks. -taj