tdb_transaction_cancel

Taj Khattra taj.khattra at gmail.com
Sat Apr 7 01:51:39 GMT 2007


hi,

re: samba-4_0 revision r22117

in tdb_transaction_cancel(), shouldn't we add

    tdb->num_lockrecs = 0;
    SAFE_FREE(tdb->lockrecs);

inside the if (tdb->num_locks != 0) block?

if yes, it seems like num_locks and num_lockrecs are always
incremented and decremented in unison, so couldn't we get rid of one
of them?

thanks.

-taj


More information about the samba-technical mailing list