Rev 11788: Import only necessary test variables, more refactoring. in file:///home/jelmer/bzr.samba/SAMBA_4_0/

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bartlett wrote:
> On Wed, 2007-04-04 at 17:24 +0200, Jelmer Vernooij wrote:
>> +foreach ("PASSWORD", "DOMAIN", "SERVER", "CONFIGURATION", 
>> +             "USERNAME", "PREFIX", "NETBIOSNAME", "KRB5_CONFIG") {
>> +       $ENV{$_} = $testenv_vars->{$_};
>> +}
> So, if we want an environment variable to be available in 'make
> testenv', or in a test, we must now list it in 3 places (the definition,
> the echo FOO=$FOO and here?
I'm trying to cut down on the number of variables as while we move to
multiple environments, these variables will be generated later on in the
process (and can differ).

For example, in the case of domain members, there are multiple PIDDIRs.

> Shouldn't we just cut down the list being echoed if this is an issue?
That too, but there are a couple of other things that rely on the
variables being echoed (such as the ldap provisioning code, which I
think should be integrated into mktestdc.sh).

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBRhTESQy0JeEGD2blAQITWAP/cb5FGIH+tzYb3HRUSlhs/Jybr1jnhrUq
xSADa79CQD2y40O9rEGfpT0aZ1CSnglvJqQ34c0jX5pcjzBM/ZHHa18mM+YHkgsT
9gJhodhGh5/A6BK9O65/psuooiCJo45yDpE0Jep/jUChmGa8NZWk+o2CHgRqkzPL
FkRPWpUx9TA=
=sHrv
-----END PGP SIGNATURE-----