HP-UX ACL code for modularized ACL-implemetation

[McCall, Don (GSE-WTEC-Alpharetta)]

 Hi Michael;
I replaced the modules/vfs_hpuxacl.c dummy with your code on an 11.23 system and rebuilt
Samba-3.0.25pre2, and I got several compiler warnings, but looking at the older code in lib/sysacls.c from 3.0.22 (That we base the current HP CIFS Server product on), I suspect these have been there all along. Specifically, the acl() implementation on HP-UX takes the following parameterlist:   
		int acl(char *pathp, int cmd, int nentries, struct acl *aclbufp);

I haven't been able to actually test functionality yet, but I'm working with one of the lab folks to put this thru their acl test suite, and I'll let you know once I have any results.

Thanks!
Don

Using FLAGS      =  -O -DWITH_SYSLOG -DGUEST_ACCOUNT="smbnull" -D_SAMBA_BUILD_=3
 -AC99 -AC99 -D_MACHINE_SYS_GETPPDP_INCLUDED -AC99 -I/usr/samba_src/samba-3.0.25
pre2/source/popt -I/usr/samba_src/samba-3.0.25pre2/source/iniparser/src -Iinclud
e -I./include  -I. -I. -I./lib/replace -I./lib/talloc -I./tdb/include -I./libadd
ns -I./librpc -DHAVE_CONFIG_H  -D_HPUX_SOURCE -D_POSIX_SOURCE -D_LARGEFILE64_SOU
RCE -D_ALIGNMENT_REQUIRED=1 -D_MAX_ALIGNMENT=4 -DMAX_POSITIVE_LOCK_OFFSET=0x1fff
fffffffLL -I/usr/local/include -DLDAP_DEPRECATED    -I/usr/samba_src/samba-3.0.2
5pre2/source/lib -D_SAMBA_BUILD_=3
      PICFLAG    = +z
      LIBS       = -lsec -lnsl -liconv -lrt
      LDFLAGS    = -L/usr/local/lib/hpux32
      DYNEXP     = -Wl,-E,+b/usr/local/lib/hpux32:/usr/lib/hpux32
      LDSHFLAGS  = -b -Wl,-B,symbolic,-b,-z -L/usr/local/lib/hpux32
      SHLIBEXT   = so
      SONAMEFLAG = -Wl,+h 
Compiling modules/vfs_hpuxacl.c
"modules/vfs_hpuxacl.c", line 294: warning #2167-D: argument of type "const char
 *" is incompatible with parameter of type "char *"
        ret = acl(name, ACL_SET, count, hpux_acl);
                  ^

"modules/vfs_hpuxacl.c", line 377: warning #2167-D: argument of type "const char
 *" is incompatible with parameter of type "char *"
        ret = acl(path, ACL_SET, count, hpux_acl);
                  ^

"modules/vfs_hpuxacl.c", line 665: warning #2167-D: argument of type "const char
 *" is incompatible with parameter of type "char *"
        *count = acl(name, ACL_CNT, 0, &dummy_ace);
                     ^

"modules/vfs_hpuxacl.c", line 675: warning #2167-D: argument of type "const char
 *" is incompatible with parameter of type "char *"
        *count = acl(name, ACL_GET, *count, *hpux_acl);
                     ^

"modules/vfs_hpuxacl.c", line 837: warning #2940-D: missing return statement at 
end of non-void function "hpux_count_obj"
  }
  ^

Linking bin/smbd
  ^

-----Original Message-----
From: Michael Adam [mailto:ma at sernet.de] 
Sent: Wednesday, March 21, 2007 12:57 PM
To: McCall, Don (GSE-WTEC-Alpharetta); samba-technical at lists.samba.org
Subject: HP-UX ACL code for modularized ACL-implemetation

Hi Don, hi samba-technical,

attached find an implementation of the hp-ux acl implementation
for the modluraized implementation of ACLs in samba. I was
working on it last summer after having converted solaris and tru64.
But I had to stop half way through. Now recently I tried to finish
this module. But i had to see that current SAMBA_3_0 does not
build on our HP-UX 11.00 here at SerNet, with all the new
lib/replace stuff. I tried really hard, but no chance. :-/

Don, do I asked you some questions about upgrading to 11.11 some
time ago, but we did not manage to upgrade yet. 

So here ist my request: The attached vfs_hpuxacl.c is tested
against an old checkout from the tm/vl-posixacls branch, which
is all I could do. I tested it yesterday and it built and worked
as it should. Now the prototype of the three main functions has
changed since (the "conn" parameter was dropped), and I adopted
the file. But I could not test it.

Could you, Don, or anyone with access to a HP-UX 11.11 machine
test this code, just replacing the dummy modules/vfs_hpuxacl.c
file in current SAMBA_3_0 ? 

This would really be great!

Cheers, Michael

-- 
Michael Adam <ma at sernet.de>
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.SerNet.DE, mailto: Info @ SerNet.DE