Q about pidl client code in Samba 3

[Gerald (Jerry) Carter]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer,

I'm looking at the return code in rpccli_winreg_EnumKey():

	/* Return variables */
	*name = *r.out.name;
	*keyclass = *r.out.keyclass;
	*last_changed_time = *r.out.last_changed_time;

keyclass and last_changed_time are unique pointers so
it seems that they should be able to be NULL in the input.
If so, then the assignments need to be surrounded by
pointer checks.  Does this make sense?

I'm trying to put together a patch to pidl now for testing.



cheers, jerry
=====================================================================
Samba                                    ------- http://www.samba.org
Centeris                         -----------  http://www.centeris.com
"What man is a man who does not make the world better?"      --Balian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.4 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFGvXOIR7qMdg1EfYRAoPdAKCNSexS3/HhSwesUlHNxe5Dlq1ZPQCfaWVI
XA1/5c6OqCWqR/ySQaguiP4=
=Pc3Z
-----END PGP SIGNATURE-----