svn commit: samba r18875 - in branches/SAMBA_3_0/source/groupdb: .

[simo]

On Mon, 2006-09-25 at 13:05 +1000, tridge at samba.org wrote:
> Simo,
> 
>  > I think we could allow empty strings when using tdb, but then we would
>  > be incompatible with ldap. 
> 
> any thoughts on doing it in ldb_msg_add_string() ? That can't break
> any existing code, as currently any code passing an empty string into
> there will get an error. Just to be sure I have tested and make test
> passes.
> 
> It also will not affect anything we do as an ldap server.

We must return an error as LDAP server when someone sends us a message
with an empty attribute.

>  > I never really liked ldb_msg_sanity_check() either but I don't think we
>  > should be silently removing attributes, we may hide a real bug that way.
> 
> how could the ldb_msg_add_string() change hide a real bug? Do you
> really think we have code that relies on getting back an error when an
> empty string is added to a ldb message ?

Nope, but if you don't set the value by mistake, and not by choice you
may not notice it (unless using an ldap server and the attribute is
mandatory).

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer
email: idra at samba.org
http://samba.org