svn commit: samba r18875 - in branches/SAMBA_3_0/source/groupdb: .

[Andrew Bartlett]

On Mon, 2006-09-25 at 08:34 +1000, tridge at samba.org wrote:
> Volker,
> 
>  > It failed to upgrade my existing group_mapping.tdb. See the
>  > attached logfile & example db.
> 
> ahh, I see, thanks!
> 
> Simo, this is triggering the check at line 607 of ldb_msg.c:
> 
> 	ldb_asprintf_errstring(ldb, "Element %s has empty attribute in ldb message (%s)!",
> 				    msg->elements[i].name, 
> 				    ldb_dn_linearize(mem_ctx, msg->dn));
> 	talloc_free(mem_ctx);
> 	return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
> 
> I guess this is a ldap standards compliance check? Are empty
> attributes always not allowed in ldap or is there some property we can
> add to allow them to be empty? Having to special case this in the
> calling code isn't the best approach I think.

LDAP doesn't support empty attributes.  Is there anything in particular
wrong with not having the attribute at all?

>  > Feel free to revert my patch and fix the bug properly.
> 
> now I see the log, your patch may in fact be the best approach without
> a change to ldb_msg_add_string(). It just surprised me, as I hadn't
> noticed that ldap compliance test in the ldb code (Simo has done a lot
> of ldap compliance work this year that I haven't gone over in detail).

I think Volker's change is correct.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060924/d21a1cc3/attachment.bin