svn commit: samba r18851 - in branches/SAMBA_4_0/source/lib/ldb/tools: .

[Andrew Bartlett]

On Sat, 2006-09-23 at 20:29 +0000, vlendec at samba.org wrote:
> Author: vlendec
> Date: 2006-09-23 20:29:54 +0000 (Sat, 23 Sep 2006)
> New Revision: 18851
> 
> WebSVN: http://websvn.samba.org/cgi-bin/viewcvs.cgi?view=rev&root=samba&rev=18851
> 
> Log:
> Some C++ warnings
> Modified:
>    branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c
> 
> 
> Changeset:
> Modified: branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c
> ===================================================================
> --- branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c	2006-09-23 19:17:50 UTC (rev 18850)
> +++ branches/SAMBA_4_0/source/lib/ldb/tools/cmdline.c	2006-09-23 20:29:54 UTC (rev 18851)
> @@ -285,7 +285,7 @@
>  			}
>  			if (ctxid[0]) {
>  				control->ctxid_len = ldb_base64_decode(ctxid);
> -				control->contextId = talloc_memdup(control, ctxid, control->ctxid_len);
> +				control->contextId = (char *)talloc_memdup(control, ctxid, control->ctxid_len);

This does raise the question of 'why are these structure members char *,
rather than uint8_t * (given they are being treated as binary data)...

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Red Hat Inc.                  http://redhat.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20060923/f8015484/attachment.bin