[PATCH] AIX BOOL conflict in tdb + largefile issue

Stefan (metze) Metzmacher metze at samba.org
Wed Sep 20 17:36:44 GMT 2006


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Peter,

thanks for that patch, I'm trying to solve this bugs currently:-)

> Attached a symptomatic treatment patch (svn.diff) for AIX. However, this BOOL 
> conflict is a much more common issue under AIX... (I've tried, 
> somehow /usr/include/stdbool.h gets included in tdb... Unfortunately, many 
> AIX headers also use _BOOL for guarding its different _Bool and friends...) 
> I'd suggest testing this patch on other platforms, too - but strongly advise 
> renaming the _BOOL macro everywhere...

we currently define BOOL_DEFINED, _BOOL_EXISTS and
__bool_true_false_are_defined in lib/replace/replace.h

do you think I should add _BOOL there too?

> BTW. this error is the same existing on another AIX machine which is 5.2 
> (http://build.samba.org/?function=View+Build;host=oehmesrs6k;tree=samba_3_0;compiler=cc)

Yes, I know about this and aix1 also fails.

> I also had to use --disable-largefile, otherwise I've got error (see 
> error2.txt). I took me some time to realize how to proceed... I'm not going 
> to solve this one.

I have a login to aix1 and try fix this.

> Index: tdb/include/tdbutil.h
> ===================================================================
> --- tdb/include/tdbutil.h	(revision 18710)
> +++ tdb/include/tdbutil.h	(working copy)
> @@ -23,6 +23,10 @@
>  
>  #include "tdb.h"
>  
> +#ifdef __bool_true_false_are_defined 
> +typedef bool BOOL;
> +#endif

doesn't this need to be #ifndef ?

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFFEXwsm70gjA5TCD8RAjRQAKCDN9D7CCEsL4AIjTKrVUqMJ+ys2QCfaNcr
4CbfAsYlt1hDfnE0McqlNPQ=
=ZsF5
-----END PGP SIGNATURE-----


More information about the samba-technical mailing list