[PATCH] split out starttls

tridge at samba.org tridge at samba.org
Tue Sep 12 19:51:50 GMT 2006


 > > It might be easier just to do a TCP_CORK setsockopt() call if we have
 > > more than one packet, then clear the TCP_CORK when we've done them
 > > all. Should be easier to code, and fast on the wire.
 > but this add 2 extra syscalls, and with writev() we'll endup with an
 > less or equal amount of syscalls.

just noticed this old email and that I hadn't replied to.

The cost of a TCP_CORK call is very very small. On the other hand,
writev() is extremely slow and inefficient on some systems (including
older linux systems). The problem is that writev() on some systems
creates separate TCP packets for each element, whereas with a cork you
get optimal packet splitting (assuming the OS supports TCP_CORK).

I also suspect our user space code will be much simpler with the cork
than the writev. That is worth it.

Cheers, Tridge

More information about the samba-technical mailing list