svn commit: samba r18012 - in branches/SAMBA_3_0: examples/libsmbclient source/libsmb

[Stefan (metze) Metzmacher]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

derrell at samba.org schrieb:
> I've never written a torture test before, and I don't know how to run the
> torture tests.  (Maybe that's something for me to learn while at the
> conference.)  Does this (untested) patch do something close to what it's
> supposed to?

> +
> +	/*
> +         * Ensure that opening the file without the leading slash works.
> +         * NetApp filers are known to fail on this.
> +         */
> +	io.openx.in.open_func = OPENX_OPEN_FUNC_OPEN;
> +	io.openx.in.fname = fname + 1;
> +	status = smb_raw_open(cli->tree, mem_ctx, &io);
> +	CHECK_STATUS(status, NT_STATUS_OK);
> +	fnum = io.openx.out.file.fnum;
> +	smbcli_close(cli->tree, fnum);
> +
> +        /* Reset io.openx.in.fname back to its proper value */
> +        io.openx.in.fname = fname;
> +
>  	smbcli_unlink(cli->tree, fname);
Hi Derrell,

that looks good, you have just whitespaces instead of tabs in front of
some lines:-)

Maybe it would be a good idea to isolate this test and create a new
function (just copy and modify test_chained())

as the RAW-OPEN test is tested with 'make test' or 'make quicktest' you
can easily test it.

to run it against a windows box use this:

bin/smbtorture //servername/sharename -U user%pass RAW-OPEN

metze
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFE/SLCm70gjA5TCD8RAm5xAKCIXAUMcTJz2q/WH1K/Wflc3/DDxwCeNQK7
S5jmutIq24EZc8GWfZtx4pw=
=3Ox6
-----END PGP SIGNATURE-----